Relocate DslHelper from root namespace to under AASM namespace #711
+26
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed because codecov <= 0.1.20 was yanked from rubygems.org. |
|
@yujideveloper Thank you for your contribution I merged #707 , can you retry travis build for your PR ? |
`DslHelper` is a module for AASM and should not be located in the root namespace.
yujideveloper
force-pushed
the
feature/relocate-dsl-helper-module
branch
from
538a8ea
to
26272ea
Compare
|
Code Climate has analyzed commit 26272ea and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 35 35
Lines 1235 1236 +1
=======================================
+ Hits 1177 1178 +1
Misses 58 58
Continue to review full report at Codecov.
|
|
@anilmaurya |
|
Thank you for your contribution 👍 @yujideveloper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I relocated
DslHelpermodule from the root namespace to under the AASM namespace.Because it is a module for AASM and should not be located in the root namespace.